Fixed assumption on out_shift for quantized linear #14789
Merged
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14789
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 94ea57b with merge base a39866c ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
1 similar comment
This PR needs a
|
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Oct 6, 2025
Summary: out shift should be int32 Reviewed By: hsharma35 Differential Revision: D83875670
DrJessop
force-pushed
the
export-D83875670
branch
2 times, most recently
from
e2c7e75 to
3b53456
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Oct 6, 2025
Summary: out shift should be int32 Reviewed By: hsharma35 Differential Revision: D83875670
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Oct 6, 2025
Summary: out shift should be int32 Reviewed By: hsharma35 Differential Revision: D83875670
Summary: Pull Request resolved: pytorch#14789 out shift should be int32 Reviewed By: hsharma35 Differential Revision: D83875670
DrJessop
force-pushed
the
export-D83875670
branch
from
3b53456 to
94ea57b
Compare
zonglinpeng
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: out shift should be int32
Differential Revision: D83875670